[22850] Fix python code generation for bounded strings (backport #440) #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Cherry-pick of 8eaca9a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
8 tasks
|
@Mergifyio rebase |
* Refs #22835. SWIG extend to set fixed_string from std::string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. SWIG export template for fixed_string members. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix access to typecode. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix max size typo. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix exported template name. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix extend code. Signed-off-by: Miguel Company <[email protected]> * Refs #22850. Apply suggestions from review. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 8eaca9a) # Conflicts: # src/main/java/com/eprosima/fastcdr/idl/templates/TypesSwigInterface.stg
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/3.3.x/pr-440
branch
from
7fbc3dd to
c71d8de
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
richiware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following improvements on the code generated for SWIG interfaces:
fixed_stringmembers receiving a standard string is added.%templatefor each fixed_string member is generated.This allows setting bounded string members with either of the following alternatives:
struct_name.member_name("string value")@Mergifyio backport 4.0.x
Contributor Checklist
Commit messages follow the project guidelines.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #440 done by [Mergify](https://mergify.com).